Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Searchable combo boxes in all unsupervised widgets #4565

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

PrimozGodec
Copy link
Contributor

Description of changes

Now when we have ComboBoxSearch available, it can be used where suitable. With this PR I am adding it to all widgets from the unsupervised section where a lot of options can be in the combo box - mostly where variables appear in combo boxes:

  • Distance Map
  • Self-organizing map
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #4565 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4565      +/-   ##
==========================================
- Coverage   83.64%   83.63%   -0.02%     
==========================================
  Files         281      276       -5     
  Lines       56259    55452     -807     
==========================================
- Hits        47060    46375     -685     
+ Misses       9199     9077     -122     

@BlazZupan
Copy link
Contributor

Works fine, but did not merge since failing checks.

@PrimozGodec
Copy link
Contributor Author

Now it can be merged. I fixed checks. Also I resolved conflicts for all other three PRs.

@BlazZupan BlazZupan merged commit 54e700e into biolab:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants