heatmap: Fix aspect preserving scaling when a part of a 'split' is empty #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
fixes/heatmap-aspect-empty-size
branch
from
22ab776
to
3cb86fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #4530 +/- ##
==========================================
- Coverage 83.37% 83.35% -0.03%
==========================================
Files 279 274 -5
Lines 55755 54959 -796
==========================================
- Hits 46485 45810 -675
+ Misses 9270 9149 -121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Workflow:
There is a extremely large empty space after Proteas section in the heatmap.
Fixes gh-4527
Description of changes
Do not attempt to scale empty widgets.
Includes