[ENH] OWImpute: Data info displayed in the status bar #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4499 +/- ##
==========================================
- Coverage 87.45% 83.33% -4.12%
==========================================
Files 405 274 -131
Lines 73924 54913 -19011
==========================================
- Hits 64649 45764 -18885
+ Misses 9275 9149 -126 |
VesnaT
requested changes
Mar 13, 2020
Orange/widgets/data/owimpute.py
Outdated
| @@ -346,6 +354,7 @@ def commit(self): | |||
|
|
|||
| if not self.data or not self.varmodel.rowCount(): | |||
| self.Outputs.data.send(self.data) | |||
| self.info.set_output_summary(self.info.NoOutput) | |||
There was a problem hiding this comment.
When self.data is not None and self.varmodel.rowCount() == 0, there actually is data on the output.
To reproduce: File (iris) -> Select columns (deselect all columns) -> Impute -> Data Table (there are 150 empty rows)
aturanjanin
changed the title
aturanjanin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Input/output data info displayed in the status bar.
Includes