[ENH] Sticky graphics header/footer views #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sticky header/footers to keep the scale visible
ales-erjavec
force-pushed
the
sticky-graphics-header-footer
branch
from
6a5390c
to
08a76b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #3930 +/- ##
=========================================
Coverage ? 84.76%
=========================================
Files ? 373
Lines ? 65107
Branches ? 0
=========================================
Hits ? 55187
Misses ? 9920
Partials ? 0 |
Codecov Report
@@ Coverage Diff @@
## master #3930 +/- ##
=========================================
Coverage ? 85.02%
=========================================
Files ? 378
Lines ? 66671
Branches ? 0
=========================================
Hits ? 56685
Misses ? 9986
Partials ? 0 |
This time with a larger margin. Ensure there are no noticeable artifacts due to device pixel ratio scaling with the display of the scale's horizontal line.
This time with a larger margin. Ensure there are no noticeable artifacts due to device pixel ratio scaling with the display of the scale's horizontal line.
... when the scene is cleared
Ensure the initial scale has the 'inverted' range (descending values from left to right) before the first dendrogram is displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-3918
Fixes gh-1745
Description of changes
Add s StickyGraphicsView utility class implementing a sticky header/footer views to anchor scene header/footer in the view.
Hierarchical Clustering: Move the top and bottom scales into the same scene as the dendrogram (and are therefore exported to image along with it - gh-3918).
Silhouette Plot: Anchor top and bottom scales in the view.
Heatmap: Anchor top dendrogram/labels and bottom labels in view when applicable (gh-1745).
Includes