Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWLinearProjection: limit axis #3885

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

robertcv
Copy link
Collaborator

Issue

Fixes #3743

Description of changes

Limit the number of displayed axis and labels length to 20.

Includes
  • Code changes
  • Tests
  • Documentation

@janezd
Copy link
Contributor

janezd commented Jun 14, 2019

@robertcv, I'm so sorry but ... could you keep just eliding and remove the limit on the number of attributes?

This widget is different from Radviz where variables are always placed around a circle; here you can place them arbitrarily (or use PCA) and the labels can overlap even with just 5 (well, just 2) attributes. So limiting their number doesn't help a lot.

Also, in Linear projection you can hide attributes whose axis are shorter than some limit. So you can have 300 atributes, run PCA and hide those with short axes. Or even hide all attributes because you'd just like to see the projection. With the limitation to 20 attributes this is no longer possible.

@robertcv robertcv force-pushed the fix/owlinearprojection_vars branch from 14d5276 to 6489e6b Compare June 26, 2019 08:00
@robertcv
Copy link
Collaborator Author

@janezd I removed the limit on the number of attributes.

@janezd janezd merged commit 1abbe2c into biolab:master Jun 26, 2019
@robertcv robertcv deleted the fix/owlinearprojection_vars branch November 19, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OWLinearProjection: legible axis labels
3 participants