[ENH] Scatterplot: Draw separate regression lines for colors; add orthonormal regression #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3518 +/- ##
==========================================
+ Coverage 83.73% 83.78% +0.04%
==========================================
Files 370 370
Lines 66451 66680 +229
==========================================
+ Hits 55643 55867 +224
- Misses 10808 10813 +5 |
|
I like this a lot! |
janezd
force-pushed
the
scatterplot-multiple-reg-lines
branch
from
598ce05
to
b2c1b7b
Compare
janezd
changed the title
janezd
force-pushed
the
scatterplot-multiple-reg-lines
branch
from
976004d
to
ff8e05f
Compare
|
This seems nicely robust. Did you intentionally decide to have different line widths for overall fit and per-class fit? The overall fit seems insignificant now, while colored lines at width=1 are hard to notice. I would set width of all of them to 2, but I do not know how it looks on retina screens. |
|
Also, documentation should be updated, but probably not in this PR. The old docs still show some discrete features. |
janezd
force-pushed
the
scatterplot-multiple-reg-lines
branch
from
ff8e05f
to
0229552
Compare
|
I changed widths to 2. I could now even remove the argument, but decided to keep it if we change our minds in the future. |
janezd
force-pushed
the
scatterplot-multiple-reg-lines
branch
2 times, most recently
from
64fc4a1
to
a077e40
Compare
janezd
force-pushed
the
scatterplot-multiple-reg-lines
branch
from
a077e40
to
6081008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It would be interesting to see separate regression lines for different colors - when points in the scatter plot are colored with discrete colors.
Also fixes #3519.
Description of changes
Includes