Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] canvas/widgetsscheme: Remove use of QObject.destroyed for logging #3447

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

An occasional NameError: free variable 'name' referenced before assignment in enclosing scope can be observed when running with debug logging level.

Description of changes

Remove use of QObject.destroyed for logging. Use weakref.finalize instead.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #3447 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3447      +/-   ##
==========================================
- Coverage   83.27%   83.27%   -0.01%     
==========================================
  Files         365      365              
  Lines       64305    64305              
==========================================
- Hits        53549    53548       -1     
- Misses      10756    10757       +1

@lanzagar lanzagar merged commit 6b20649 into biolab:master Dec 10, 2018
@ales-erjavec ales-erjavec deleted the fixes/destroy-logging branch May 20, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants