Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] python-framework.sh: Fix 'Current' symlink creation #3373

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

From #3370 (comment)

It looks to me that the python-framework.py script would create a new symlink inside the Current folder if the symlink already exists.

This is exactly what happens

Description of changes

Do not follow target if it already exists and points to a directory

Includes
  • Code changes
  • Tests
  • Documentation

Do not follow target if it already exists and points to a directory
@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #3373 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3373      +/-   ##
==========================================
- Coverage   82.25%   82.25%   -0.01%     
==========================================
  Files         351      351              
  Lines       62450    62450              
==========================================
- Hits        51371    51367       -4     
- Misses      11079    11083       +4

@lanzagar lanzagar added this to the 3.18 milestone Nov 9, 2018
@lanzagar lanzagar merged commit bf61ea4 into biolab:master Nov 9, 2018
@ales-erjavec ales-erjavec deleted the fixes/framework-current-link branch May 20, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants