Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Canvas: 'Window Groups' continued #3085

Merged
merged 9 commits into from
Aug 10, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Applies on top of #3066

Cleanup and extend 'Window Groups' functionality.

Description of changes
  • Add a 'Bring widget to front' action/shortcut ctrl + down_arrow
  • Preserve window stacking order for saved/activated window groups.
  • Move implementation for save/restore window group to WidgetManager.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Jun 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0f84885). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3085   +/-   ##
=========================================
  Coverage          ?   82.63%           
=========================================
  Files             ?      340           
  Lines             ?    58790           
  Branches          ?        0           
=========================================
  Hits              ?    48580           
  Misses            ?    10210           
  Partials          ?        0

@BlazZupan BlazZupan requested a review from astaric July 6, 2018 07:12
@ales-erjavec ales-erjavec force-pushed the canvas/window-groups-continued branch from 8cb2bd4 to 40711da Compare July 6, 2018 08:14
@lanzagar
Copy link
Contributor

lanzagar commented Aug 3, 2018

ctrl + down_arrow does not seem to do anything on my system... (but if if works for others I am fine with the explanation that my system is strange :))

Also I find the wording of these menu options a bit confusing (Bring widgets to front, Display widgets on top).

@ajdapretnar
Copy link
Contributor

On my system, ctrl+down_arrow works. However, when the focus is on a widget, it behaves like regular up/down, despite holding ctrl. For example, when in Edit Domain, ctrl+down_arrow would walk through a list of variables and not bring widgets to front. If this is by design, I'm fine with that. I just thought adding ctrl would have a different functionality than down_arrow used on its own.

One more thing. It is not a consequence of this PR, but since the PR is meant to work on extended screens, I'll just mention it. My full screen Orange looks weird.

screen shot 2018-08-03 at 14 06 21

@ales-erjavec
Copy link
Contributor Author

ctrl+down_arrow works only when the canvas has focus. It's intended as a counterpart to the ctrl + up_arrow in the widget and a more light-weight version of the window groups.

@lanzagar lanzagar added this to the 3.16 milestone Aug 10, 2018
@lanzagar lanzagar merged commit 1012e20 into biolab:master Aug 10, 2018
@ales-erjavec ales-erjavec deleted the canvas/window-groups-continued branch September 12, 2018 10:08
@ales-erjavec ales-erjavec mentioned this pull request Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants