[FIX] OWScatterOWScatterPlotGraph: Match group colors with marker colors #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
changed the title
VesnaT
changed the title
markotoplak
reviewed
Jun 5, 2018
| mask = (selection != 0) | ||
| selection = selection.copy() | ||
| selection[mask] = selection[mask] - 1 | ||
| selection[~mask] = selection[~mask] = max_sel |
There was a problem hiding this comment.
Why not just subtract 1 from everything and then replace -1 with something else?
There was a problem hiding this comment.
Because in some cases array's dtype is "uint8". In that case subtracting 1 from 0 results in 255.
I was thinking about changing dtype, but I think the above solution is more robust.
VesnaT
force-pushed
the
scatter_plot_group_colors
branch
from
7029b5d
to
c13d5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3051
Description of changes
Includes