[FIX] VizRank: Fix race condition in toggle
#3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a race condition in the `toggle` method where VizRank could be left without a running worker thread. This could happen between setting keep_running from False to True and subsequent call to QThread.start. The worker could read keep_running as False right before that and not yet exit before the call to start. Then start would be a noop and the thread would stop right after. Fix by explicitly joining on the thread on 'pause' as a synchronization point.
Codecov Report
@@ Coverage Diff @@
## master #3042 +/- ##
==========================================
+ Coverage 82.37% 82.37% +<.01%
==========================================
Files 335 335
Lines 57811 57812 +1
==========================================
+ Hits 47621 47622 +1
Misses 10190 10190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There was a race condition in the
togglemethod where VizRank couldbe left without a running worker thread. This could happen between
setting
keep_runningfrom False to True and subsequent call toQThread.start. The worker could readkeep_runningas False rightbefore that and not yet exit before the call to start. Then start would
be a noop and the thread would stop right after.
This manifests in a sometimes failing
Orange.widgets.visualize.tests.test_owmosaic.MosaicVizRankTests.test_pause_continueDescription of changes
Fix by explicitly joining the thread on 'pause' as a synchronization point.
Includes