Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owselectcolumns: Fix performance on filtering with selection #3030

Merged

Conversation

ales-erjavec
Copy link
Contributor

Issue

Select Attributes has severe performance degradation on filtering a long list of variables (in the Available view) when all the variables are selected.

For example:
File ('geo-gds360') -> Select Attributes
move all variables to Available view, press Ctrl + A and enter any text in the Filter

Description of changes
  • Coalesce the calls to update_interface_state using a single shot timer.
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the select-attributes-selection-filter branch from 83cd322 to fe007c7 Compare May 11, 2018 09:28
@codecov-io
Copy link

codecov-io commented May 11, 2018

Codecov Report

Merging #3030 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
+ Coverage   82.19%   82.21%   +0.01%     
==========================================
  Files         335      335              
  Lines       57688    57683       -5     
==========================================
+ Hits        47417    47422       +5     
+ Misses      10271    10261      -10

@ales-erjavec ales-erjavec force-pushed the select-attributes-selection-filter branch from fe007c7 to b1bf6cc Compare May 11, 2018 09:30
@lanzagar
Copy link
Contributor

Improves filtering, but just to ask - how hard would it be to speed up drag and drop too? Dragging all features to Available in geo-gds360 takes a looong time.

@lanzagar lanzagar merged commit a8ea66b into biolab:master May 16, 2018
@ales-erjavec ales-erjavec deleted the select-attributes-selection-filter branch May 16, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants