Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Heat Map: Allow labeling by TimeVariable #3026

Merged
merged 1 commit into from
May 25, 2018

Conversation

ajdapretnar
Copy link
Contributor

Issue

Heat map didn't allow labeling rows by TimeVariable.

Description of changes

Enable labeling by TimeVariable.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #3026 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3026   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files         335      335           
  Lines       57688    57688           
=======================================
  Hits        47417    47417           
  Misses      10271    10271

@lanzagar lanzagar changed the title Enable labeling by TimeVariable [FIX] Heat Map: Allow labeling by TimeVariable May 16, 2018
@lanzagar
Copy link
Contributor

It also did not allow labeling by ContinuousVariable.
Any argumentation about which variables should be allowed as annotations?

@ajdapretnar
Copy link
Contributor Author

No argumentation. I just needed TimeVariable. I can easily add ContinuousVariable.

@rokgomiscek rokgomiscek merged commit b9af80e into biolab:master May 25, 2018
@ajdapretnar ajdapretnar deleted the heat-time branch November 30, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants