Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix variable type guessing #2998

Merged
merged 1 commit into from
Apr 17, 2018
Merged

[FIX] Fix variable type guessing #2998

merged 1 commit into from
Apr 17, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-2997

Description of changes
  • Preserve original_values to pass to guess_data_type.
  • Add a namask argument to it.
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec
io: Fix variable type guessing
f10e681 
* Preserve `original_values` to pass to `guess_data_type`.
* Add a namask argument to it.
@astaric
Copy link
Member

astaric commented Apr 13, 2018

Thanks, this solves the problem I had

@astaric astaric merged commit 1503597 into biolab:master Apr 17, 2018
@PrimozGodec PrimozGodec added this to the 3.13 milestone Apr 17, 2018
@ales-erjavec ales-erjavec deleted the fixes/io-guess-data-type branch April 24, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.
3 participants
@ales-erjavec @astaric @PrimozGodec