Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Speed-up prediction by circumventing Instance-specific prediction. #2959

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

thocevar
Copy link
Contributor

Issue

Improves #2957

Description of changes

Convert an Instance to a Table with a single row right from the start. Handling a Table with a single instance seems to be more efficient than handling an individual Instance, which results in several conversions to a Table anyway.

Speed-up in the case mentioned in #2957 is by more than a factor of 7.

Includes
  • Code changes
  • Tests
  • Documentation

@thocevar thocevar changed the title Speed-up prediction by circumventing Instance-specific prediction. [ENH] Speed-up prediction by circumventing Instance-specific prediction. Mar 16, 2018
@thocevar thocevar requested a review from astaric March 21, 2018 08:10
@astaric astaric added this to the 3.12 milestone Mar 21, 2018
Copy link
Member

@astaric astaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@thocevar thocevar assigned thocevar and unassigned thocevar Mar 22, 2018
@lanzagar lanzagar changed the title [ENH] Speed-up prediction by circumventing Instance-specific prediction. [FIX] Speed-up prediction by circumventing Instance-specific prediction. Mar 22, 2018
@lanzagar lanzagar merged commit a17563a into biolab:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants