Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ContextHandler: Merge local context into globals before serialization #2837

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue

Start a fresh canvas session

File (iris) -> Scatter Plot

Change (one of) the selected axis variable. Remove the Scatter Plot and restart canvas and create the workflow again. The previous axis selection is not restored. Change the selection again. Remove the Scatter Plot widget then recreate (and connect) it again. The selected axis selection is restored. Restart canvas and recreate the workflow. The selected axis selection is restored.

Description of changes

Make the settings persistence consistent.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #2837 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2837   +/-   ##
=======================================
  Coverage   81.96%   81.96%           
=======================================
  Files         321      321           
  Lines       54841    54841           
=======================================
  Hits        44952    44952           
  Misses       9889     9889

@astaric astaric merged commit 551153a into biolab:master Dec 19, 2017
@ales-erjavec ales-erjavec deleted the settings-context-merge-ordering branch December 20, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants