-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Windows installers: Python lookup #2827
Conversation
To find 32 bit python >= 3.5 it is necessary to add explicit -32 suffix to the tag name (sys.winver - PEP 514)
Add a start menu shortcut for droping into the activated env.
Allow the nsis installer to save the selected folder name in the registry
Codecov Report
@@ Coverage Diff @@
## master #2827 +/- ##
==========================================
+ Coverage 81.95% 81.96% +0.01%
==========================================
Files 321 321
Lines 54823 54841 +18
==========================================
+ Hits 44928 44952 +24
+ Misses 9895 9889 -6 |
Is there a way to specify the order of entries in the start menu? Currently Orange Command Prompt comes before Orange. (miniconda installer) |
I have tested the miniconda stuff and it works. Not sure how to reproduce the regular installer problem though. |
The 32-bit regular installers for Python >= 3.5 did not work at all. They would fail with "Python installation failed (cannot determine Python installation prefix)" or with a pip error "...win32.whl is not a supported wheel on this platform" depending on whether 64 bit Python was already installed. To reproduce the error create a installer on master
and try running it. |
Thanks. As the new installers work (for me) I am merging this. |
Issue
Description of changes
Includes