Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Scatter Plot Graph: max discrete values colors and shape #2804

Merged
merged 3 commits into from
Dec 11, 2017
Merged

[ENH] Scatter Plot Graph: max discrete values colors and shape #2804

merged 3 commits into from
Dec 11, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Nov 28, 2017

Issue

Fixes #2782

Description of changes

screenshot_20171205_120034

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Nov 28, 2017

Codecov Report

Merging #2804 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2804      +/-   ##
==========================================
+ Coverage    76.2%   76.21%   +0.01%     
==========================================
  Files         337      337              
  Lines       59665    59697      +32     
==========================================
+ Hits        45470    45501      +31     
- Misses      14195    14196       +1

@lanzagar lanzagar added this to the 3.9 milestone Nov 29, 2017
@jerneju jerneju changed the title [WIP][ENH] Scatter Plot Graph: max discrete values colors and shape [ENH] Scatter Plot Graph: max discrete values colors and shape Dec 1, 2017
Copy link
Contributor

@lanzagar lanzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I have a much worse color pallete (gradient from red to blue with many similar colors).
  • Triangle appears twice in shapes
  • "Other" marker does not have the right color in the picture (different from legend)
  • Maybe for next PR : picture and legend should have the exact same colors/symbols

@jerneju
Copy link
Contributor Author

jerneju commented Dec 6, 2017

I have a much worse color palette (gradient from red to blue with many similar colors).

Color palette is variable dependent. See variable.py.

@lanzagar
Copy link
Contributor

lanzagar commented Dec 6, 2017

Color palette is variable dependent. See variable.py.

Which means your changes here are problematic because they do not handle this...
The colors are determined based on the variable (number of values), but you change the values before plotting. So you can't use the palette for a variable with e.g. 100 values after merging that into 11 values.

@lanzagar lanzagar merged commit f81cea1 into biolab:master Dec 11, 2017
@jerneju jerneju deleted the spg-discrete branch December 11, 2017 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants