-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Scatter Plot Graph: max discrete values colors and shape #2804
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
==========================================
+ Coverage 76.2% 76.21% +0.01%
==========================================
Files 337 337
Lines 59665 59697 +32
==========================================
+ Hits 45470 45501 +31
- Misses 14195 14196 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have a much worse color pallete (gradient from red to blue with many similar colors).
- Triangle appears twice in shapes
- "Other" marker does not have the right color in the picture (different from legend)
- Maybe for next PR : picture and legend should have the exact same colors/symbols
Color palette is variable dependent. See |
Which means your changes here are problematic because they do not handle this... |
Issue
Fixes #2782
Description of changes
Includes