-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] errorreporting: Remove use of pip internal api #2724
Conversation
Pip 10 will move all internal APIs.
Codecov Report
@@ Coverage Diff @@
## master #2724 +/- ##
==========================================
+ Coverage 76.03% 76.03% +<.01%
==========================================
Files 338 338
Lines 59628 59628
==========================================
+ Hits 45339 45341 +2
+ Misses 14289 14287 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traceback (most recent call last):
File "/venv/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2459, in version
return self._version
File "/venv/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2545, in __getattr__
raise AttributeError(attr)
AttributeError: _version
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/orange3/Orange/canvas/application/errorreporting.py", line 245, in handle_exception
return ErrorReporting.handle_exception(exc)
File "/usr/lib/python3.5/unittest/mock.py", line 1157, in patched
return func(*args, **keywargs)
File "/orange3/Orange/canvas/application/errorreporting.py", line 195, in handle_exception
for dist in pkg_resources.working_set))
File "/orange3/Orange/canvas/application/errorreporting.py", line 195, in <genexpr>
for dist in pkg_resources.working_set))
File "/venv/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2464, in version
raise ValueError(tmpl % self.PKG_INFO, self)
ValueError: ("Missing 'Version:' header and/or PKG-INFO file", Orange [unknown version] (/orange3))
-------------------------------------------------------------------------------
Fatal Python error: Cannot recover from stack overflow.
Which version of setuptools do you have installed ( How was orange3 installed and what does |
|
As documented accessing `version` can raise ValueError.
I was unable to duplicate the error, but the error is part of the documented Distribution.version behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it does not crash and a list of installed packages with their versions is sent to the server.
Issue
Error reporting uses internal pip api, which will be moved in Pip 10.
Description of changes
Remove use of pip internal api
Includes