Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Paint Data: now stores data in list and not np.array #2314

Merged
merged 1 commit into from
Jun 2, 2017
Merged

[FIX] Paint Data: now stores data in list and not np.array #2314

merged 1 commit into from
Jun 2, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented May 15, 2017

Issue

https://sentry.io/biolab/orange3/issues/240133185/

Steps to reproduce the behavior

One way to reproduce this behavior:
Use Paint Data widget and draw some points. Then save it. Close the Orange. Open the Orange and then load the file and close the Orange again. Error should be thrown.

These steps were tested in Orange versions master, 3.4.2, 3.4.1 and 3.3.12. In all those versions error occurred.

Includes
  • Code changes
  • Tests
  • Documentation

@jerneju
Copy link
Contributor Author

jerneju commented May 15, 2017

@astaric
Copy link
Member

astaric commented May 15, 2017

How can the error be reproduced by user? (= not in code)?

@jerneju
Copy link
Contributor Author

jerneju commented May 15, 2017

@astaric : Now added above.

@jerneju jerneju changed the title [FIX] Schemeedit: compering properties does not always work [FIX] Schemeedit: comparing properties does not always work May 16, 2017
@codecov-io
Copy link

codecov-io commented May 16, 2017

Codecov Report

Merging #2314 into master will increase coverage by 0.04%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #2314      +/-   ##
==========================================
+ Coverage   73.27%   73.31%   +0.04%     
==========================================
  Files         317      317              
  Lines       55447    55452       +5     
==========================================
+ Hits        40630    40656      +26     
+ Misses      14817    14796      -21

@jerneju
Copy link
Contributor Author

jerneju commented May 16, 2017

Changed Paint Data. Now stores points in List. Therefore settings are saved in literal format and not pickle.

@jerneju jerneju changed the title [FIX] Schemeedit: comparing properties does not always work [FIX] Paint Data: now stores data in list and not np.array May 25, 2017
@jerneju jerneju added this to the 3.4.3 milestone Jun 2, 2017
@lanzagar lanzagar merged commit 6758462 into biolab:master Jun 2, 2017
@jerneju jerneju deleted the value-schemeedit branch June 2, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants