[FIX] Fix invalid settings reuse in File widget #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaric
force-pushed
the
file-match-values
branch
from
f70f9e1
to
8440ab4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2137 +/- ##
==========================================
- Coverage 71.49% 67.47% -4.02%
==========================================
Files 318 318
Lines 54423 54428 +5
==========================================
- Hits 38908 36725 -2183
- Misses 15515 17703 +2188Continue to review full report at Codecov.
|
As domain editor shows variable's values, it should only reuse settings when two discrete variables have the same settings.
astaric
force-pushed
the
file-match-values
branch
from
8440ab4
to
ee02816
Compare
jerneju
approved these changes
Mar 27, 2017
| def test_context_match_includes_variable_values(self): | ||
| file1="""\ | ||
| var | ||
| a b |
There was a problem hiding this comment.
Why did you not add two or three more tabs? For instance see https://github.com/biolab/orange3/pull/2120/files#diff-27440f7faaa4fc96168ff656e6891bdeR154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When files with similar domain (same variable names, different values of discrete vars) were opened, domain editor always showed values from the first opened file.
Fixes gh-2132
Description of changes
ContextHandler now takes variable's values in account.
Includes