-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Scatterplot: Implement grouping of selections #2070
Conversation
7079244
to
64177cf
Compare
@astaric, I defined a GUI for this. :) |
Codecov Report
@@ Coverage Diff @@
## master #2070 +/- ##
==========================================
+ Coverage 70.15% 70.21% +0.05%
==========================================
Files 315 315
Lines 54096 54209 +113
==========================================
+ Hits 37952 38061 +109
- Misses 16144 16148 +4 Continue to review full report at Codecov.
|
table = Table( | ||
domain, data.X, data.Y, | ||
metas=np.hstack((data.metas, selection.reshape(len(data), 1)))) | ||
table.attributes = data.attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table.ids = data.ids
addcd1d
to
e27ddd1
Compare
radon fails because of an additional case in the switch-ish I'd rather not improve a cc score of a totally unrelated method just to make radon happy. |
c1319b2
to
3705ad7
Compare
3705ad7
to
3c0efd3
Compare
3c0efd3
to
5052b08
Compare
Instead of annotating selected data with "No" and "Yes", use G0, G1, G2 ... when data is selected is subsequent groups using Shift or Cmd/Ctrl modifier.
Connect File -> Scatter plot, and then Scatter plot to a Table and also to another Scatter plot, both through signal Data (not Selection). Now select several groups in the first scatter plot by using the Shift modifier and see the results in the other scatter plot and table.
The change does not affect the other Scatter plot's output.
We can add a check box "Group selections" to enable or disable this behaviour. However, I think this should be the default behaviour and I see little reason why the user would want to disable it.
Includes