[FIX] ScatterPlot: Fix crash when coloring by column of unknowns #2061
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2061 +/- ##
=========================================
+ Coverage 68.84% 69.94% +1.1%
=========================================
Files 315 315
Lines 53965 54006 +41
=========================================
+ Hits 37152 37776 +624
+ Misses 16813 16230 -583Continue to review full report at Codecov.
|
| In case when all column values are NaN then it throws that error. | ||
| GH-2061 | ||
| """ | ||
| dat = """\ |
There was a problem hiding this comment.
Is there a special reason why the dataset is generated in this way? (and not with table like in https://github.com/biolab/orange3/pull/2057/files#diff-1a66c8eae521f07f1c5d904e0cd025a7R117)?
There was a problem hiding this comment.
No particular reason at all. Now changed.
| data = TabReader(file).read() | ||
| self.send_signal("Data", data) | ||
|
|
||
| self.widget.graph.attr_color = self.widget.get_shown_attributes()[1] |
There was a problem hiding this comment.
Could you select attributes using helpers found in https://github.com/biolab/orange3/blob/master/Orange/widgets/tests/utils.py#L268?
astaric
changed the title
astaric
changed the title
ValueError cannot convert float NaN to integer owscatterplot In case when all column values are NaN then it throws that error. https://sentry.io/biolab/orange3/issues/196744604/
| @@ -409,7 +409,7 @@ def handleNewSignals(self): | |||
| self.graph.new_data(self.data_metas_X, self.subset_data) | |||
| if self.attribute_selection_list and \ | |||
| all(attr in self.graph.domain | |||
| for attr in self.attribute_selection_list): | |||
| for attr in self.attribute_selection_list): | |||
There was a problem hiding this comment.
This was indented OK before.
There was a problem hiding this comment.
Pylint complained and that is why I added 4 spaces.
Issue
ValueError cannot convert float NaN to integer owscatterplot
In case when all column values are NaN then it throws that error.
https://sentry.io/biolab/orange3/issues/196744604/
Description of changes
Logarithm of zero and division by zero are prevented.
Includes