Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWPredictions: Fix crash when opening report #1884

Merged
merged 1 commit into from
Jan 9, 2017

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 6, 2017

Issue

The widget crashes when predictor's domain differs from data domain (and trying to open report)

Description of changes

Fixes #1883
To reproduce, use Iris dataset to learn on and Titanic dataset to make predictions for.

Includes
  • Code changes
  • Tests
  • Documentation

The widget crashed when predictor's domain differed from data domain.
@codecov-io
Copy link

codecov-io commented Jan 6, 2017

Current coverage is 89.25% (diff: 100%)

Merging #1884 into master will not change coverage

@@             master      #1884   diff @@
==========================================
  Files            86         86          
  Lines          9100       9100          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           8122       8122          
  Misses          978        978          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update e6cdc76...86774df

@VesnaT VesnaT changed the title OWPredictions: Fix crash when opening report [FIX] OWPredictions: Fix crash when opening report Jan 6, 2017
@VesnaT VesnaT added this to the 3.3.10 milestone Jan 6, 2017
@lanzagar lanzagar merged commit ae6e05a into biolab:master Jan 9, 2017
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 10, 2017
[FIX] OWPredictions: Fix crash when opening report
(cherry picked from commit ae6e05a)
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 11, 2017
[FIX] OWPredictions: Fix crash when opening report
(cherry picked from commit ae6e05a)
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 13, 2017
[FIX] OWPredictions: Fix crash when opening report
(cherry picked from commit ae6e05a)
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 18, 2017
[FIX] OWPredictions: Fix crash when opening report
(cherry picked from commit ae6e05a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants