Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owconfusionmatix: Add migrate_settings #1796

Merged

Conversation

ales-erjavec
Copy link
Contributor

Issue

ref #1794

For some period of time the 'selected_learner' property was changed from List[int] -> int (4e49bb3) and then back again (8a492d7)

When opening a workflow that was saved between that time (between releases 3.3.4 and 3.3.7) the widget would raise an exception

Traceback (most recent call last):
  File "/Users/aleserjavec/workspace/orange3/Orange/canvas/scheme/widgetsscheme.py", line 822, in process_signals_for_widget
    handler(*args)
  File "/Users/aleserjavec/workspace/orange3/Orange/widgets/evaluate/owconfusionmatrix.py", line 225, in set_results
    prev_sel_learner = self.selected_learner.copy()
AttributeError: 'int' object has no attribute 'copy'
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

Fix an error when restoring from a workflow that was saved when
the `selected_learner` settings was an int
@codecov-io
Copy link

codecov-io commented Dec 2, 2016

Current coverage is 88.96% (diff: 100%)

Merging #1796 into master will not change coverage

@@             master      #1796   diff @@
==========================================
  Files            82         82          
  Lines          8963       8963          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7974       7974          
  Misses          989        989          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 11c3f11...14b9a0f

@janezd janezd merged commit a107be4 into biolab:master Dec 2, 2016
@ales-erjavec ales-erjavec deleted the fixes/confusionmatrix-migrate-settings branch January 27, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants