[FIX] MDS and Distances widges fix #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ales-erjavec
commented
Jul 8, 2016
ales-erjavec
commented
- Add more input data checks in MDS widget
- Preserve selected metric in 'Distances' widget
The input data (if used as a source for distances) should have at least 2 rows and at least one regular attribute.
Since ecf4e9a any time the input data is received the selected metric would be reset (to "Cosine"). Instead of changing the set of presented metrics, only set/update their enabled state. Also reintroduce 'fixed' metrics ordering so that 'similar' metrics are again grouped together.
Current coverage is 87.92%@@ master #1435 diff @@
==========================================
Files 77 77
Lines 7584 7584
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6668 6668
Misses 916 916
Partials 0 0
|
|
This nicely solves the problem of remembering the same distance metrics for the data in the same domain. I have tried this on dense data. Could somebody, say @nikicc, test on sparse data and then merge. |
|
@BlazZupan I tested it on sparse and did not find any problems so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.