-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select Rows - do not change filter after column change if it is not required #4737
Comments
Indeed, it requires all variables. It suppose it would be possible to modify the context handler by relaxing the match method and adding
This happens on your request. :) Some time ago we modified the behaviour of contexts to match the most recent context. This is not fixable (= not compatible with the current strategy), but may no longer matter after/if we fix the first point. |
Yes, the second comment was just because I remembered that we previously discussed that Orange remembers contexts and was not sure if my main request would be irrelevant because of it. Maybe Orange could have options in widgets to set how to remember things? (If that would not be too cluttering.) The best remembering option is highly context dependent. |
Actually, #4740 might fulfill all your wishes (regarding the Select Rows widget, that is). Try it. I wouldn't let the user select the way contexts are matched because few people would understand what it does. |
The #4740 did not change the behaviour. |
Hm, it worked for me. Have you tried with clear settings? |
Yes, but still the old behaviour. I tried on my workflow and on Iris - I first set the filter to is outside and then changing the numerical column which set the filter back to equals. |
I can confirm. The dropdown changes to default. |
That is not what I meant. The problem arises if you consider only the topmost filter: Also, out of topic: it looks a bit odd that the field heights are different between the filter columns on your video/operating system. But I like the spacing between them (there is no spacing on the Linux i am using). |
When performing filtering with Select Rows the filters are reset after changing the column on which the filtering is performed. This is annoying when one has multiple similar columns that require the same filters. Could there be an option not to reset the filter columns, except if necessary due to a variable type change?
Additionally, even if a filter is changed from colA to colB and back to colA the previous settings used for colA are not retained.
Version:
Orange 3.26.
The text was updated successfully, but these errors were encountered: