Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Rows - do not change filter after column change if it is not required #4737

Closed
Hrovatin opened this issue May 5, 2020 · 9 comments · Fixed by #4755
Closed

Select Rows - do not change filter after column change if it is not required #4737

Hrovatin opened this issue May 5, 2020 · 9 comments · Fixed by #4755
Assignees

Comments

@Hrovatin
Copy link
Contributor

Hrovatin commented May 5, 2020

When performing filtering with Select Rows the filters are reset after changing the column on which the filtering is performed. This is annoying when one has multiple similar columns that require the same filters. Could there be an option not to reset the filter columns, except if necessary due to a variable type change?
Additionally, even if a filter is changed from colA to colB and back to colA the previous settings used for colA are not retained.

Version:
Orange 3.26.

@janezd
Copy link
Contributor

janezd commented May 5, 2020

When performing filtering with Select Rows the filters are reset after changing the column on which the filtering is performed.

Indeed, it requires all variables. It suppose it would be possible to modify the context handler by relaxing the match method and adding filter_values to remove non-matching conditions.

Additionally, even if a filter is changed from colA to colB and back to colA the previous settings used for colA are not retained.

This happens on your request. :) Some time ago we modified the behaviour of contexts to match the most recent context. This is not fixable (= not compatible with the current strategy), but may no longer matter after/if we fix the first point.

@Hrovatin
Copy link
Contributor Author

Hrovatin commented May 5, 2020

Yes, the second comment was just because I remembered that we previously discussed that Orange remembers contexts and was not sure if my main request would be irrelevant because of it. Maybe Orange could have options in widgets to set how to remember things? (If that would not be too cluttering.) The best remembering option is highly context dependent.

@janezd
Copy link
Contributor

janezd commented May 5, 2020

Actually, #4740 might fulfill all your wishes (regarding the Select Rows widget, that is). Try it.

I wouldn't let the user select the way contexts are matched because few people would understand what it does.

@Hrovatin
Copy link
Contributor Author

Hrovatin commented May 5, 2020

The #4740 did not change the behaviour.

@janezd
Copy link
Contributor

janezd commented May 5, 2020

Hm, it worked for me. Have you tried with clear settings?

@Hrovatin
Copy link
Contributor Author

Hrovatin commented May 6, 2020

Yes, but still the old behaviour. I tried on my workflow and on Iris - I first set the filter to is outside and then changing the numerical column which set the filter back to equals.

@ajdapretnar
Copy link
Contributor

I can confirm. The dropdown changes to default.

@janezd
Copy link
Contributor

janezd commented May 6, 2020

What am I missing? What am I doing differently?

select-rows

@Hrovatin
Copy link
Contributor Author

Hrovatin commented May 7, 2020

That is not what I meant. The problem arises if you consider only the topmost filter:
First you have: sepal length, is outside, [2,4].
Then you change this first filter to sepal width (leaving other two parameters intact). Expected: sepal width, is outside, [2,4]. Actual: sepal width, equals, 2.
So the second and third column change, although only the first column was changed manually. Since both original and new variable are of the same type the change of the second and third column is not necessary. I would expect the other two columns to remain unchanged (or be set to whatever was previously used for the new variable (sepal width), if this is the Orange way of doing things). Although in my use case I would strongly prefer if second and third column remain as they are. Namely, I had problems in past when things changed by themselves and I did not notice it.

Also, out of topic: it looks a bit odd that the field heights are different between the filter columns on your video/operating system. But I like the spacing between them (there is no spacing on the Linux i am using).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants