Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color: Renaming variables is broken #4666

Closed
lanzagar opened this issue Apr 17, 2020 · 2 comments · Fixed by #4669
Closed

Color: Renaming variables is broken #4666

lanzagar opened this issue Apr 17, 2020 · 2 comments · Fixed by #4669
Assignees
Labels
bug A bug confirmed by the core team

Comments

@lanzagar
Copy link
Contributor

Describe the bug
After renaming a variable in the Color widget all its values are unknown/missing (?).

Orange version:
3.25

@lanzagar lanzagar added bug report Bug is reported by user, not yet confirmed by the core team bug A bug confirmed by the core team and removed bug report Bug is reported by user, not yet confirmed by the core team labels Apr 17, 2020
@ajdapretnar
Copy link
Contributor

I don't think Color should enable renaming variables. I mean... why? We have Edit Domain for that.

@janezd janezd self-assigned this Apr 17, 2020
@janezd
Copy link
Contributor

janezd commented Apr 17, 2020

It's sometimes practical - we can also change a color for a certain value and rename it.

It is also quite nicely implemented, integrated into models, tested... Removing this functionality would require rewriting the widget (or keeping a lot of unused stuff in it). Fixing this issue is trivial - it was just a missing argument. #4669 is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug confirmed by the core team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants