Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplyDomain widget: 'Retain all data' checkbox is now redundant #3787

Closed
mstrazar opened this issue May 9, 2019 · 0 comments · Fixed by #3800
Closed

ApplyDomain widget: 'Retain all data' checkbox is now redundant #3787

mstrazar opened this issue May 9, 2019 · 0 comments · Fixed by #3800
Assignees
@VesnaT
Labels
snack This will take an hour or two

Comments

@mstrazar
Copy link
Contributor

mstrazar commented May 9, 2019 •
edited
Loading

After #3526 was implemented in parallel with other work on Apply Domain, the "Retain all data" checkbox and its action can now be removed. Currently, the result is a sert of duplicated columns (in meta).

Example workflow:
apply_domain_iris.ows.zip

screen
@janezd janezd added the snack This will take an hour or two label May 9, 2019
@mstrazar mstrazar assigned VesnaT and unassigned AndrejaKovacic May 15, 2019
@VesnaT VesnaT mentioned this issue May 15, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VesnaT VesnaT

Labels
snack This will take an hour or two
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply domain: Remove 'Retain all data' option VesnaT/orange3
4 participants
@janezd @mstrazar @VesnaT @AndrejaKovacic