-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table.from_numpy crashes on Inf values #2788
Comments
Do we really want to allow inf values in X/Y? IMHO they should be converted to nan (=unknowns) before the table is constructed. |
I agree with @astaric. A table with inf values is a corrupted table. |
When calculating new features out of existing ones, But if we don't support them, I will convert them to |
An argument for this is that ScatterPlot seems to be handling |
This need to be resolved. I vote for converting inf to nan. @lanzagar @BlazZupan if you agree, let us propose a solution so someone can implement this. |
I don't see enough benefit in supporting inf values for the amount of problems I expect we would encounter in various widgets, at least for now. |
Orange version
3.8.0.dev0+301d13a
Expected behavior
One can create
Table
withfrom_numpy
that contains infinity values.Actual behavior
ValueError
Array contains infinity.
is raised in_check_arrays
, not really sure why.Steps to reproduce the behavior
Pass numpy array with inf values to
Table.from_numpy
Additional info (worksheets, data, screenshots, ...)
The text was updated successfully, but these errors were encountered: