Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run add-on installation when failing on a package #2407

Closed
ajdapretnar opened this issue Jun 16, 2017 · 4 comments
Closed

Re-run add-on installation when failing on a package #2407

ajdapretnar opened this issue Jun 16, 2017 · 4 comments

Comments

@ajdapretnar
Copy link
Contributor

Orange version

3.5.dev

Expected behavior

Add-ons that can be installed, get installed on Orange.

Actual behavior

When one add-on installation fails, the add-on window closes and none of the checked add-ons after the failing one gets installed.

Steps to reproduce the behavior

Windows. Try to install Networks or Timeseries. Then tick an add-on that is listed after one of these two. The add-ons fail and the final add-on doesn't get installed because the windows closes.

Additional info (worksheets, data, screenshots, ...)

Can we make the add-on installation continue after the error was reported? Perhaps catch the error, write it as the status of the add on (e.g. Timeseries - Error), then run the installation for the rest of the selected add-ons?

@ajdapretnar
Copy link
Contributor Author

Probably fixed in #2561.

@astaric
Copy link
Member

astaric commented Sep 8, 2017

Not really. I plan to remove that commit from #2561, as it causes more problems I do not want to tackle in that PR.

@ajdapretnar
Copy link
Contributor Author

Ok. 😞

@janezd janezd added the needs discussion Core developers need to discuss the issue label Jul 13, 2019
@janezd janezd removed the needs discussion Core developers need to discuss the issue label Aug 30, 2019
@janezd
Copy link
Contributor

janezd commented Jan 10, 2020

Moved to biolab/orange-canvas-core#71.

@janezd janezd closed this as completed Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants