Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owfile: Memory errors #1713

Closed
lanzagar opened this issue Nov 4, 2016 · 2 comments
Closed

owfile: Memory errors #1713

lanzagar opened this issue Nov 4, 2016 · 2 comments

Comments

@lanzagar
Copy link
Contributor

lanzagar commented Nov 4, 2016

Orange version

3.3.8

Expected behavior

Orange shows an error when an operation runs out of memory.
(Might be hard to catch?)

Actual behavior

Orange crashes with error reporting option shown.

Steps to reproduce the behavior

The reported error crashed in apply_edit_domain:
https://github.com/biolab/orange3/blob/master/Orange/widgets/data/owfile.py#L419
But we need to consider other locations with big memory allocations.

Additional info (worksheets, data, screenshots, ...)
@ajdapretnar
Copy link
Contributor

@lanzagar What is the status of this? I know @jerneju has been dealing with memory errors diligently some time ago.

#2521
#2441
#2374
#2397
#2316

But nothing has been done regarding the File widget. Could we sample, just like in SQL? If the file is too big, load only the first n lines and m columns? (column restriction should probably be very loose)

@lanzagar
Copy link
Contributor Author

I think this was opened as a more general todo item, for us to consider. As it is over a year old, we can probably close this and work on specific problems encountered more recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants