Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Demo Screenshots not visible #4

Open
daviddao opened this issue Dec 2, 2014 · 1 comment
Open

Demo Screenshots not visible #4

daviddao opened this issue Dec 2, 2014 · 1 comment
Assignees
Labels

Comments

@daviddao
Copy link
Member

daviddao commented Dec 2, 2014

BioJS Registry Demo Screenshots are not visible anymore. This is quite annoying because now you can not see, if a component has a demo or not. Why not instead replace non existent/buggy screenshots with our old 'demo shield' ?

@wilzbach
Copy link
Member

wilzbach commented Dec 2, 2014

BioJS Registry Demo Screenshots are not visible anymore.

They do work for me (> 70%).

Well the screenshoter is unfortunately is a bit tricky to handle.

  • it only reloads the resources if you request them (I already increased the cache to 8h)
  • for some components it terminates (they produce errors ... )

The screenshoter uses this package with this custom patch

Why not instead replace non existent/buggy screenshots with our old 'demo shield'

Hmm I also dislike the demo shields, but I guess as a temporary solution until we figure out why the screenshooter is failing for so many components this is fine :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants