Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox status page empty #85

Open
jmetz opened this issue May 2, 2024 · 4 comments
Open

Sandbox status page empty #85

jmetz opened this issue May 2, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jmetz
Copy link
Collaborator

jmetz commented May 2, 2024

          > EDIT: Also @oeway will likely have to upgrade and restart the upload service for this to work.

I suppose that service restart has not happened yet..
status page looks like this rn:

image

Originally posted by @FynnBe in #84 (comment)

@jmetz jmetz self-assigned this May 2, 2024
@jmetz jmetz added the bug Something isn't working label May 2, 2024
@jmetz
Copy link
Collaborator Author

jmetz commented May 2, 2024

As suspected, this bug is due to a missing file:

https://uk1s3.embassy.ebi.ac.uk/public-datasets/sandbox.bioimage.io/collection_staged.json

does not exist, whereas:

https://uk1s3.embassy.ebi.ac.uk/public-datasets/bioimage.io/collection_staged.json

does exist.

@FynnBe - would you consider this a collection issue then?

@jmetz
Copy link
Collaborator Author

jmetz commented May 2, 2024

Note: @oeway + @FynnBe : even the non-sandbox page doesn't work from the preview, because
deploy-preview-84--bioimageio-uploader.netlify.app is not
in the allowed list for CORS on S3; in principle we'd have to add a wildcard-domain to that list like *bioimageio-uploader.netlify.app but as anyone can take a subdomain that ends with bioimageio-uploader, this would be considered
bad practice in general.

Do you think I should temporarily allow that @oeway ? I could add eg deploy-preview-*--bioimageio-uploader.netlify.app.

@jmetz
Copy link
Collaborator Author

jmetz commented May 2, 2024

@oeway: temporarily added the above wildcard domain - in theory, as the top-level domain is still netlify this massively reduces the potential for misuse, and it may also be that netlify reserve deploy-preview* subdomains (though that's just a guess / wishful thinking perhaps 😅 ).

Let me know if you'd like me to turn that off again.

@jmetz
Copy link
Collaborator Author

jmetz commented May 2, 2024

Technically neither of the above issues (missing file on S3 and S3 CORS issue) are really directly related to this repo. but will leave this open until they're both resolved for anyone else who thinks to log this as an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant