Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model downloader does not update filenames in architecture for pytorch_state_dict #371

Open
k-dominik opened this issue Jan 16, 2024 · 0 comments

Comments

@k-dominik
Copy link
Member

Hello,

I've noticed that the model downloader fails to create a self-contained .zip file for models in pytorch_state_dict format. I've observed this with impartial-shrimp. While the zip file contains all files necessary to run, the containing rdf.yaml does not point to the downloaded files for the archictecture, and readme for some reason:

rdf.yaml (abbreviated) for "impartial-shrimp":
...
description: Neuron segmentation in EM, trained on the CREMI challenge data.
documentation: https://zenodo.org/api/records/5874742/files/documentation.md/content
format_version: 0.4.5
...
weights:
  pytorch_state_dict:
    architecture: >-
      https://zenodo.org/api/records/5874742/files/unet.py/content:AnisotropicUNet
    architecture_sha256: 7f5b15948e8e2c91f78dcff34fbf30af517073e91ba487f3edb982b948d099b3
    kwargs:
      anisotropic_kernel: false
      final_activation: Sigmoid
      gain: 2
      in_channels: 1
      initial_features: 32
      out_channels: 1
      postprocessing: null
      return_side_outputs: false
      scale_factors:
        - - 1
          - 3
          - 3
        - - 1
          - 3
          - 3
        - - 2
          - 2
          - 2
        - - 2
          - 2
          - 2
        - - 2
          - 2
          - 2
    sha256: 9123de8cd1b9e7d4eaef56cb9d780a4dcbcfdf4b33f85559f6f392eeb06f6920
    source: ./weights.pt

I think the zip file should be self contained - and while it does not contain the markdown for the documentation, it does contain the architecture file and should point to it locally, not to zenodo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant