Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #14

Open
ctr26 opened this issue Nov 23, 2023 · 2 comments
Open

Logging #14

ctr26 opened this issue Nov 23, 2023 · 2 comments

Comments

@ctr26
Copy link

ctr26 commented Nov 23, 2023

Would it be easy to adding more info logging about what the model is so I can get metrics on the cluster?

@jmetz
Copy link
Collaborator

jmetz commented Nov 23, 2023

Adding logging that prints out the model's __repr__() or similar wouldn't be hard.

I'm not sure though what that will contain - by default not much unless it's a dataclass.

Is there more info you can provide about how you'd want to collect those metrics?

Presumably json output or similar would be best if you're going to parse the logs and use that data elsewhere? Though in that scenario it could make more sense to directly report that information somewhere else, without parsing the logs.

More info would help narrow down what's needed/most suitable.

@ctr26
Copy link
Author

ctr26 commented Nov 24, 2023

As a minimum the bioengine-model-runners config is be happy with.

I guess my confusion at a glance is that the repo does do info logging but it doesn't seem to report it on triton, cellpose does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants