Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH workflows are misconfigured for PRs #13

Open
jmetz opened this issue Nov 10, 2023 · 2 comments
Open

GH workflows are misconfigured for PRs #13

jmetz opened this issue Nov 10, 2023 · 2 comments
Assignees
@oeway @FynnBe

Comments

@jmetz
Copy link
Collaborator

jmetz commented Nov 10, 2023

See eg https://github.com/bioimage-io/bioengine-model-runner/actions/runs/6826837523/job/18567617730?pr=11

The PR seems to be triggering the full set of GH Actions including build-and-upload... that should only be triggered on a merge IMO.

The PR should only trigger tests etc.
@jmetz
Copy link
Collaborator Author

jmetz commented Nov 10, 2023

Also the call to the test_triton_models script happens in the "build-and-upload" workflow.

The "Test" workflow does nothing (as far as I can tell).

@jmetz
Copy link
Collaborator Author

jmetz commented Nov 10, 2023

... and said test_triton_models happens as the last step of the "build-and-upload" workflow. Not sure if it should happen sooner (like really not sure as I don't know this system like you guys)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oeway oeway

@FynnBe FynnBe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oeway @jmetz @FynnBe