report overhaul phase 1 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidysymons
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Aside from the specific code note about managing container width, there are a few issues:
- The menu does not have any notion of breakpoints for tablets/mobile devices and breaks down (visually) in smaller formats
- The font colors on the menu do not conform to the Figma document
- The dimensions and spacing of the menu items do not conform to the Figma document
Please let me know if you're unsure how to extract precise parameters from the Figma doc or if you have any questions.
Comment on lines
19
to
20
| padding-left: 100px; | ||
| padding-right: 100px; |
There was a problem hiding this comment.
Container widths should be managed with the width and max-width parameters, not padding or margin. This approach yields poor results on smaller screens.
There was a problem hiding this comment.
I originally used width but was met with unexpected behavior. I think it has to do with the stylings of the other divs, I'll see about arranging them differently for different results.
cassidysymons
requested changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For phase one we will convert the existing side menu into the new top menu.