You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Haven't thoroughly tested and I'm not 100% so writing an issue instead of a pull request, but on the engramv2 notebook, a few functions (including the ones that score layouts) have this normalization
Notice that F2 is calculated with newMininstead of newMin2. It seems to me that this is wrong and should even fail (there's no newMin defined in the function), but goes unnoticed because of the normalization of the Flow and Strength matrices; as these are done in the global scope and with the variable newMin
I think this wouldn't change the rankings for the data used in this project because newMin2 will always be 0 (there's no 24 key layout that doesn't hit at least one 0 frequency bigram), so every F2 having the same newMin was going to happen anyways. But I haven't tested this. And this is definitely inflating the scores as the minimum values in the data_matrix are higher.
The text was updated successfully, but these errors were encountered:
Haven't thoroughly tested and I'm not 100% so writing an issue instead of a pull request, but on the engramv2 notebook, a few functions (including the ones that score layouts) have this normalization
Notice that F2 is calculated with
newMin
instead ofnewMin2
. It seems to me that this is wrong and should even fail (there's nonewMin
defined in the function), but goes unnoticed because of the normalization of the Flow and Strength matrices; as these are done in the global scope and with the variablenewMin
I think this wouldn't change the rankings for the data used in this project because
newMin2
will always be 0 (there's no 24 key layout that doesn't hit at least one 0 frequency bigram), so every F2 having the samenewMin
was going to happen anyways. But I haven't tested this. And this is definitely inflating the scores as the minimum values in thedata_matrix
are higher.The text was updated successfully, but these errors were encountered: