Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Error: Empty Button on Submenu dropdown #100

Open
cdils opened this issue Nov 11, 2021 · 3 comments
Open

Accessibility Error: Empty Button on Submenu dropdown #100

cdils opened this issue Nov 11, 2021 · 3 comments

Comments

@cdils
Copy link
Collaborator

cdils commented Nov 11, 2021

I'm not sure if this is actually an accessibility issue based on context, but the WAVE accessibility checker is flagging the sub-menu dropdown as an error (empty button).

Steps to reproduce

  1. Run this URL through Wave (site is using a modified version of EA Genesis Child theme)
  2. Observe Error

Images of error

image
image

Code referenced

'<button' . ea_amp_nav_dropdown( $args->theme_location, $depth ) . ' tabindex="-1">%s</button>',

HTML output from that code

<button class="submenu-expand" tabindex="-1">
     <svg class="svg-icon" width="8" height="8" aria-hidden="true" role="img" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
            <path fill-rule="evenodd" d="M11.993 19.5a2.17 2.17 0 01-1.66-.78L.915 7.57a1.901 1.901 0 01.187-2.574 1.723 1.723 0 012.475.135l8.236 9.752a.236.236 0 00.18.085c.07 0 .135-.031.18-.085L20.41 5.13a1.734 1.734 0 011.693-.627c.632.127 1.148.6 1.35 1.236a1.904 1.904 0 01-.381 1.83l-9.416 11.148a2.18 2.18 0 01-1.663.784z"></path>
     </svg>
</button>
@cre8tivediva
Copy link

I was just searching for an answer to this. I am running up against that with the Wave checker as well.

@cdils
Copy link
Collaborator Author

cdils commented Feb 8, 2022

I was just searching for an answer to this. I am running up against that with the Wave checker as well.

Based on context, the code looks fine to me, so I just ended up ignoring the error.

@cre8tivediva
Copy link

@cdils it's flagging my menu item that has the # sign on the custom menu item that doesn't lead to anywhere. All of my other submenus work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants