From 4891dc899ccea06c97fd28063b6ea59d6ba2a3db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lucas=20Serv=C3=A9n=20Mar=C3=ADn?= Date: Tue, 4 May 2021 11:39:17 +0200 Subject: [PATCH] CONTRIBUTING.md: follow up GO* variable cleanup (#4159) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bonus, remove reference to GOROOT, which does not need to be referenced: https://dave.cheney.net/2013/06/14/you-dont-need-to-set-goroot-really. Signed-off-by: Lucas Servén Marín --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2aa81dc638..91a7f952f3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -92,14 +92,14 @@ component of the Thanos distributed system. We recommend: * Find any directory in your system your want Thanos repo in. e.g `~/Repos` - * `cd ~/Repos` - * Make sure you have GOBIN, GOPATH and GOPROXY (useful) set to PATH. For example - + * Make sure that the GOBIN, GOPATH and GOPROXY (useful) environment variables are set and that GOBIN is included in your PATH. For example - ``` export GOBIN="~/Repos/thanos/.bin" # It's nice to have local tooling installed and stored locally. - export GOPATH="~/Repos/thanosgopath" # Use if you want to have an isolated directory for deps, otherwise, the dir where you have installed golang will be used. + export GOPATH="~/Repos/thanosgopath" # Use if you want to have an isolated directory for deps, otherwise, the directory where you have installed golang will be used. export GOPROXY="https://proxy.golang.org" - export PATH="$GOBIN:$GOROOT/bin:$PATH" + export PATH="$GOBIN:$PATH" ``` * Consider adding the environment variables to your host machine (e.g `/.bashrc` or [`.envrc`](https://direnv.net/)) file so that those environment variables are persisted across sessions.