Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle old IE JavaScript errors #268

Open
G0dwin opened this issue Sep 1, 2017 · 1 comment
Open

Handle old IE JavaScript errors #268

G0dwin opened this issue Sep 1, 2017 · 1 comment

Comments

@G0dwin
Copy link
Member

G0dwin commented Sep 1, 2017

We get reports for JS fatals for IE 8 and 9 due to the use of unsupported calls like querySelector. For the most part these errors are handled so that the error doesn't affect the ability to use the site, but the errors are still thrown and we get frequent error report emails about them.

The easiest thing to do would be to do a simple check and not execute certain portions of the code if objects don't exist.

@G0dwin
Copy link
Member Author

G0dwin commented Sep 1, 2017

TypeError: Cannot find function addEventListener in object [object HTMLDivElement]. (script in https://en.bikebike.org/ from (160, 9) to (164, 10)|_|/html/body/script#162)
  at https://en.bikebike.org/:162:undefined
Object doesn't support property or method 'querySelector'
  at https://en.bikebike.org/user/confirm/8a7c1ff80b152c1327acc41c8a9bd979cd37e1e5040551bfd04c7d136a39d703/:147:undefined
NS_ERROR_FAILURE: @https://en.bikebike.org/assets/quill-dd692e038768cf33a1cb4026fab85175afbbbc7e0ea6a0c5fcbf101f5fa4515a.js:2:6430
Unable to get value of the property 'add': object is null or undefined
  at https://en.bikebike.org/user/confirm/bc7f05147ed73ff1b63a252abfb9aabf53ba81dffc0d458351b90b013873f696/:148:undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant