Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-5284 [new]: Shipping Provider API, add digital wallets #2073

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

bc-andreadao
Copy link
Collaborator

@bc-andreadao bc-andreadao commented Oct 4, 2023

DEVDOCS-5284

What changed?

  • Add paragraph about how Shipping Provider APIs should handle incomplete postal codes (from digital wallets)

@bigcommerce/team-shipping

@bc-andreadao bc-andreadao requested a review from vborinsk October 4, 2023 20:11
benpratt77
benpratt77 previously approved these changes Oct 8, 2023
agchan12
agchan12 previously approved these changes Oct 8, 2023
@bc-andreadao
Copy link
Collaborator Author

Thanks @agchan12 @benpratt77

Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment to improve the readability. I am open to other suggestions.

@bc-andreadao bc-andreadao dismissed stale reviews from agchan12 and benpratt77 via cf6de2c October 9, 2023 17:08
Co-authored-by: Traci Porter <[email protected]>
@bc-andreadao bc-andreadao merged commit 710dfb1 into main Oct 9, 2023
2 checks passed
@bc-andreadao bc-andreadao deleted the DEVDOCS-5284-digital-wallet-postcode branch October 9, 2023 17:20
@@ -496,6 +496,8 @@ When you uninstall an app with an associated shipping carrier, you also automati
The response payload will display shipping quotes from lowest to highest price.
</Callout>

Shipping provider integrations should plan to handle incomplete postcodes when handling shipping quotes. Incomplete postcodes can occur when stores use [digital wallets](https://support.bigcommerce.com/s/article/Online-Payment-Methods?language=en_US#digital-wallet) as a payment method. Digital wallets truncate postcodes for shipping addresses in the UK and Canada as they only provide the first three characters to shipping provider integrations.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth putting this somewhere more prominently or make it easier to spot like in an info/warning style panel?

I would also add that postcodes are truncated only at time of shipping quotation, and are subsequently available/complete once the order is placed (knowing that some shipping providers also read the Order data after order placement to pull details/update costs).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vborinsk for the feedback. I created PR 2074 for this if you can approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants