Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old releases, broken functions, V3 support #95

Open
dsoprea opened this issue May 14, 2021 · 1 comment
Open

Old releases, broken functions, V3 support #95

dsoprea opened this issue May 14, 2021 · 1 comment

Comments

@dsoprea
Copy link

dsoprea commented May 14, 2021

The README.md suggests that api.Products.iterall() and api.Products.count() should exist but they do not appear to.

Also, the releases page says that the last release was 2019. They're haven't been any substantial updates since then?

Also, the forum entry at #59 says the following:

Hi @sabotagebeats, the pagination values you're referring to come from the V3 BC API, whereas this library is for the older V2 API and has not yet been updated for V3.

Has V3 been since released?

Lastly, when I call (api).Products.all() for some page equal-to-or-greater-than the page-count (the page after the last page of results), I get a single string with a value of "_connection" back. So, when there are products, we get a Product. Otherwise, we get a string with "_connection". I would expect an empty result or, at worst, a None. Can you explain what's going on here? How is pagination supposed to work? I'm having issues finding documentation and what little documentation is available (above) seems broken or inaccurate. Since the source-code is reflective, there are no clues there, either.

@argoapps
Copy link

I tried following the v3 update at #86 under the "Files changed" tab to add v3 compatibility, but I'm getting a 401 due to X-Auth-Client and X-Auth-Token headers not working as they do with the v2 api_path. Have you tried adding the extra code from #86? I can't help with any of the other issues though, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants