Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No checksum in the webhook callback request #8

Open
swayhead opened this issue May 29, 2020 · 6 comments
Open

No checksum in the webhook callback request #8

swayhead opened this issue May 29, 2020 · 6 comments

Comments

@swayhead
Copy link

My application is receiving callback POST requests from the webhook with data payload as expected.
However, there is no checksum in the URL included.

I registered the callback URL as https://xxx.yy/kivi/registerEvent/

I expect to receive the request as https://xxx.yy/kivi/registerEvent/?checksum=12345 like mentioned in the documentation https://docs.bigbluebutton.org/dev/webhooks.html#callback-format

Instead I am getting the original URL without parameters:
image

Is there any adjustment on the server I am missing?

Thanks

@Erika31
Copy link

Erika31 commented May 29, 2020

Try to set
auth2_0: false
in /usr/local/bigbluebutton/bbb-webhooks/config/default.yml

Then
bbb-conf --restart
should do the trick...

But I don't know if this configuration resists over the time...!

@swayhead
Copy link
Author

swayhead commented Jun 1, 2020

Ok. As far as I could see from the code, this flag sets the authorization bearer in the header.
I'm now looking for the checksum-param in the URL and, if empty, I check for the bearer string against the BBB-secret. It works.
Thank you.

@Erika31
Copy link

Erika31 commented Jun 1, 2020

Well, IMHO, I think that the BBB-Secret should not be transmitted over the network. On a non-secured connection, it means the BBB-Secret is revealed, which is too dangerous...
More, it thus looses its integrity-check feature...

@swayhead
Copy link
Author

swayhead commented Jun 2, 2020

And right you are.
Though the connection is secure, this surely is not a best practice.

@kiano0sh
Copy link

kiano0sh commented Jul 1, 2020

@swayhead Right now I'm facing the same problem (even over a secure network), I looked over headers and found an authorization header which is the shared secret of my bbb server and I think with that secret and domain value in body it is also possible to authorize the request. let me know if you figure it out.

@ulfgebhardt
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants