Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes to 'Site' Settings #85

Closed
jonnywatersbb opened this issue Jul 31, 2024 · 2 comments
Closed

Proposed changes to 'Site' Settings #85

jonnywatersbb opened this issue Jul 31, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jonnywatersbb
Copy link
Member

jonnywatersbb commented Jul 31, 2024

Remove

Border

Or at least move it to the bottom of the list, seems odd to have it first when it seemingly doesn't have any impact on the border of the site?

Add

Color

As well as changing background and text colour, I think this is where we should be able to manage the theme colour palette (#84)

Layout

There doesn't seem to be a way to handle the layout, width & padding in themer. See Style Book:
Screenshot 2024-07-31 at 14 54 33

Really I think the 'Site' settings should be able to edit the same level of settings that you find in Style Book:

Screenshot 2024-07-31 at 14 56 35
@jonnywatersbb jonnywatersbb added the enhancement New feature or request label Jul 31, 2024
@g-elwell
Copy link
Member

g-elwell commented Aug 8, 2024

There are two main attributes on the theme.json - styles and settings. Currently, our UI only provides components for interacting with styles. settings is on the roadmap, and should be straightforward from a technical POV based on how the plugin works so far, but would require some decisions to be made regarding the UX. I think we should create a dedicated issue for exploring settings support as a high priority to follow on from the 1.0.0 release.

Layout, colour palette and typography are all part of the settings in theme.json - see tt4 as an example

The site border does have an effect, but I agree we could look at changing the order so that the more commonly used options appear first.

@g-elwell
Copy link
Member

Closing this as I think it's now invalid since border has been moved as requested in #92. We also have #94 to discuss support for adding settings controls generally in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants