-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change visual preview to code view #62
Comments
thanks @chrishall0 and @squarewave17 for picking this up in #68 🙌 just a heads up - whilst we encourage reviews from everyone, code shouldn't be merged until it's been approved by someone from the lead engineering team or a named codeowner on a repo. on this one, I've just tested the PR and it looks good, but I do have some feedback:
|
|
My apologies @g-elwell 🙏🏻 |
What problem does this address?
Removing visual preview as described in (#61)
What is your proposed solution?
Replace with a live text view of the
theme.json
file, allowing users to instantly see the change in the code effected by altering a setting in the themer UIAcceptance criteria
The text was updated successfully, but these errors were encountered: