Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native icons release #214

Closed
wants to merge 5 commits into from
Closed

Native icons release #214

wants to merge 5 commits into from

Conversation

mohitharshan123
Copy link
Contributor

Description

Checklist

  • I have made corresponding changes to the documentation.

@unnitallman unnitallman temporarily deployed to neeto-icons-pr-214 September 4, 2023 06:29 Inactive
@unnitallman unnitallman temporarily deployed to neeto-icons-pr-214 September 4, 2023 06:35 Inactive
@mohitharshan123
Copy link
Contributor Author

@AbhayVAshokan _A Now neeto-icons and neeto-icons-rn are published as separate packages. So I think since the version was not updated in neeto-icon-rn package.json, neeto-icons-rn still has the old version code https://www.npmjs.com/package/@bigbinary/neeto-icons-rn?activeTab=code. Should we create a separate label and edit the workflow for releasing only neeto-icons-rn as needed?

@AbhayVAshokan
Copy link
Member

Once all the generation configurations are set up, it is very unlikely that there will be PRs specific to neeto-icons-web or neeto-icons-rn. Any new PR will be to add a new icon which should involve release on both sides.

I would suggest that the existing workflow is updated so that the package.json file of the @bigbinary/neeto-icons-rn package is also updated on every new release. This would maintain the consistency in the labels during the release process.

      - name: Bump the patch version and create git tag on release
        if: ${{ contains(github.event.pull_request.labels.*.name, 'patch') }}
        run: yarn version --patch

      - name: Bump the minor version and create git tag on release
        if: ${{ contains(github.event.pull_request.labels.*.name, 'minor') }}
        run: yarn version --minor

      - name: Bump the major version and create git tag on release
        if: ${{ contains(github.event.pull_request.labels.*.name, 'major') }}
        run: yarn version --major

@mohitharshan123 _a can you please make the necessary changes in the workflow so that this change is reflected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants