Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests (CI) running Matlab/Octave for popular BV readers: FieldTrip, EEGLAB, Brainstorm #83

Open
sappelhoff opened this issue May 22, 2022 · 3 comments
Labels
effort:high estimated high effort task impact:high estimated high impact task maintenance
Milestone

Comments

@sappelhoff
Copy link
Member

Having such a CI can help us ensure that what we write is not only read by MNE-Python, but also the other important packages.

This would be especially nice to have before addressing things like #77 #44

@sappelhoff sappelhoff added maintenance impact:high estimated high impact task effort:high estimated high effort task labels May 22, 2022
@sappelhoff sappelhoff added this to the 0.7.0 milestone May 22, 2022
@cbrnr
Copy link
Collaborator

cbrnr commented May 22, 2022

Is there something official from Brain Products that's open source? I'd also consider BioSig (if it has a BV reader, not sure).

@sappelhoff
Copy link
Member Author

No, they only have the proprietary brain vision analyzer, which needs a physical license dongle (at least somewhere on the network).

+1 for biosig, if many people use it

@cbrnr
Copy link
Collaborator

cbrnr commented May 23, 2022

+1 for biosig, if many people use it

No idea if many people still use it, but is has always been a reader with support for a lot of formats. If it is not too much effort I'd add it to the test matrix just to get another "opinion". There are Python bindings available, so it's probably easiest to use that instead of the C library directly (or the MATLAB version, which uses a different codebase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:high estimated high effort task impact:high estimated high impact task maintenance
Projects
None yet
Development

No branches or pull requests

2 participants