From f75582090c0ee23432f586321a8ef7ed415d359e Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Sat, 13 Apr 2024 03:40:31 -0400 Subject: [PATCH] Fixup and enhance invocation of run_tests.sh ATM it would complain that rc is not legit command due to all those spaces. Because no set -e used it just continues. Also made it executable and adjusted shebang to be universaly working. There should be no need to invoke directly via bash -- shebang would do that --- .github/workflows/validate_datasets.yml | 2 +- README.md | 4 ++-- run_tests.sh | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) mode change 100644 => 100755 run_tests.sh diff --git a/.github/workflows/validate_datasets.yml b/.github/workflows/validate_datasets.yml index 0ed566aa6..d90ee7635 100644 --- a/.github/workflows/validate_datasets.yml +++ b/.github/workflows/validate_datasets.yml @@ -86,5 +86,5 @@ jobs: - name: Validate all BIDS datasets using bids-validator run: | cat ./run_tests.sh - bash ./run_tests.sh + ./run_tests.sh shell: bash diff --git a/README.md b/README.md index afb90f648..c763045ea 100644 --- a/README.md +++ b/README.md @@ -67,7 +67,7 @@ script that is provided in this repository. This script makes use of the handles some special case examples (see [Validator Exceptions](#validator-exceptions)). -Simply run `bash run_tests.sh` in a command line from the root of the +Simply run `./run_tests.sh` in a command line from the root of the `bids-examples` repository. ### Validator exceptions @@ -304,4 +304,4 @@ DO NOT EDIT DIRECTLY. |:------------------------------------------------------------------------------------------------------------|:--------------------------------------------------------------------------------------------|:--------------------------------|:-------------------------------------------------------------------------------------------------------------|:-------------------------------------------------|:-------------------------------------------| | [ds000117](https://github.com/bids-standard/bids-examples/tree/master/ds000117) | A multi-subject, multi-modal human neuroimaging dataset of 19 subjects on a MEG visual task | anat, beh, dwi, fmap, func, meg | T1w, beh, bold, channels, coordsystem, dwi, events, headshape, magnitude1, magnitude2, meg, phasediff, scans | [link](https://openneuro.org/datasets/ds000117/) | [@RikHenson](https://github.com/RikHenson) | | [eeg_ds003645s_hed_demo](https://github.com/bids-standard/bids-examples/tree/master/eeg_ds003645s_hed_demo) | Shows usage of Hierarchical Event Descriptor (HED) in .tsv files | eeg, beh | channels, eeg, events, participants, scans | [link](https://openneuro.org/datasets/ds003645) | [@VisLab](https://github.com/VisLab) | -| [synthetic](https://github.com/bids-standard/bids-examples/tree/master/synthetic) | A synthetic dataset | anat, beh, func | T1w, beh, bold, events, physio, scans, sessions, stim | n/a | [@effigies](https://github.com/effigies) | \ No newline at end of file +| [synthetic](https://github.com/bids-standard/bids-examples/tree/master/synthetic) | A synthetic dataset | anat, beh, func | T1w, beh, bold, events, physio, scans, sessions, stim | n/a | [@effigies](https://github.com/effigies) | diff --git a/run_tests.sh b/run_tests.sh old mode 100644 new mode 100755 index 7c3f06ce5..3e12d0df9 --- a/run_tests.sh +++ b/run_tests.sh @@ -1,6 +1,6 @@ -#!/bin/bash +#!/usr/bin/env bash -rc = 0; +rc=0; for i in $(ls -d */ | grep -v node_modules); do echo "Validating dataset" $i